[Core] Fix format_url to allow leading slash if specified#45218
Merged
pvaneck merged 1 commit intoAzure:mainfrom Feb 17, 2026
Merged
[Core] Fix format_url to allow leading slash if specified#45218pvaneck merged 1 commit intoAzure:mainfrom
pvaneck merged 1 commit intoAzure:mainfrom
Conversation
pvaneck
force-pushed
the
core-format-url-fix
branch
from
b8228ae to
7c19b8d
Compare
The previous adjustment to `format_url` of always removing the trailing slash was too aggressive as some scenarios depend on a slash before the query parameters. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
core-format-url-fix
branch
from
7c19b8d to
4f5e007
Compare
Member
Author
|
Did some manual live test runs, and they appear fine (the failures are pre-existing/flakiness). Other pipeline failures are attributed to an unrelated mindependency conflict in |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression in PipelineClient.format_url where leading slashes before query parameters were being incorrectly stripped. The previous fix in version 1.38.1 that removed trailing slashes when URL templates contained only query parameters was too aggressive and broke scenarios where a leading slash before query parameters was intentional (e.g., "/?restype=service&comp=properties").
Changes:
- Fixed
_urljointo strip leading slashes from paths during joining (avoiding double slashes) instead of stripping them informat_url - Reverted Azure Tables test workarounds that were added to handle the incorrect URL formatting behavior
- Added comprehensive test coverage for various URL formatting scenarios with query strings
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/core/azure-core/azure/core/pipeline/transport/_base.py | Moved leading slash stripping from format_url to _urljoin to preserve intentional leading slashes before query parameters |
| sdk/core/azure-core/tests/test_pipeline.py | Added tests for format_url with various query string patterns and HttpRequest objects |
| sdk/core/azure-core/tests/test_basic_transport.py | Extended _urljoin tests to cover leading slash handling and query parameter scenarios |
| sdk/tables/azure-data-tables/tests/test_table_service_properties.py | Removed version check workaround and unused imports, restoring original test expectations |
| sdk/tables/azure-data-tables/tests/test_table_service_properties_async.py | Removed version check workaround and unused imports, restoring original test expectations |
| sdk/tables/azure-data-tables/tests/test_table_service_properties_cosmos.py | Removed version check conditional that was working around the URL formatting bug |
| sdk/tables/azure-data-tables/tests/test_table_service_properties_cosmos_async.py | Removed version check conditional and unused imports |
| sdk/tables/azure-data-tables/assets.json | Updated test recording assets reference to reflect re-recorded tests |
| sdk/core/azure-core/CHANGELOG.md | Added bug fix entry for the leading slash preservation fix |
pvaneck
requested review from
annatisch,
iscai-msft,
johanste,
kashifkhan,
lmazuel and
xiangyan99
as code owners
annatisch
approved these changes
Feb 17, 2026
lmazuel
approved these changes
Feb 17, 2026
Member
lmazuel
left a comment
lmazuel
left a comment
There was a problem hiding this comment.
Quick look seems valid, thanks!
Member
Author
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous adjustment to
format_urlof always removing the trailing slash was too aggressive as some scenarios depend on a slash before the query parameters.Reverting tables test changes with the addition of this fix.